pocket
pocket copied to clipboard
[P2P] Host/port shouldn't be required in client debug mode
Objective
Improve user experience of the debug CLI.
Origin Document
Goals
- Debug CLI command is usable when
hostname
andport
P2P config fields are absent or empty string
Deliverable
- Update P2P module
#Create()
logic to setm.listenAddrs = libp2p.NoListenAddrs
ifisClientDebugMode
(regardless of `m.cfg.ConnectionType) - Remove
POCKET_P2P_HOSTNAME
env var fromcli-client.yaml
manifest - Fix resulting or related bugs and/or errors
Non-goals / Non-deliverables
- Modifying the P2P config
- Modifying
Network
implementations
General issue deliverables
- [ ] Update the appropriate CHANGELOG(s)
- [ ] Update any relevant local/global README(s)
- [ ] Update relevant source code tree explanations
- [ ] Add or update any relevant or supporting mermaid diagrams
Testing Methodology
TODO
- [ ] All tests:
make test_all
- [ ] LocalNet: verify a
LocalNet
is still functioning correctly by following the instructions at docs/development/README.md - [ ] *k8s LocalNet: verify a
k8s LocalNet
is still functioning correctly by following the instructions here
Creator: [github username of the creator] Co-Owners: [optional - github usernames of the co-owner(s)]
@bryanchriswhite Is this ticket stilll relevant?