pokeclicker icon indicating copy to clipboard operation
pokeclicker copied to clipboard

feat(hatchery): allow eggs and fossils in queue

Open shallotmama opened this issue 2 years ago • 3 comments

Adds the ability to put eggs and fossils in the queue.

Closes #1362

shallotmama avatar Jun 12 '22 22:06 shallotmama

image

shallotmama avatar Jun 12 '22 23:06 shallotmama

(Have not tested it yet. Just took a quick look) The breeding window still has both the "full queue" and "no empty slots" warning. I don't think there are any situations anymore, that only cares about empty slots? So we should remove that. And the implementation looks cool! It's how i would had made it, if i ever found time to do it.

Jaaslet avatar Jun 13 '22 17:06 Jaaslet

The three types are all string literal union types pulled from enums, so they don't make sense as their own classes. I did a little cleanup though, and I think it's a lot clearer now.

The main complication was that EggItemType and the image files use the format of <type>_egg while everything else just uses the type name. I don't know why I was doing the weird conversions instead of just doing it the way it is now. 😆

shallotmama avatar Jun 16 '22 20:06 shallotmama

This PR has gotten a bit stale and collected a bunch of conflicts (our fault, sorry about that), I'm going to close this one and if you are still interested in doing this you can redo/rebase your current work over the latest develop and open a new PR.

Aegyo avatar Nov 06 '22 17:11 Aegyo