poire-z

Oh right, I misread the request - not having any long-press in corner, and focused on scroll-in-corner, I read that as disabling corner-scroll when in select mode. Despite not using...

I remember that when building UI stuff, it has happened that I made stuff bigger than the screen and have it centered so parts of the bigger stuff is offscreen...

(Didn't know about EMULATE_READER_VIEWPORT.) Just tried it, and there's indeed something fishy: the remnants of thick line on the side do not even align with the ones show by the...

Should we really save the rgbcolor (`#FF0000`) in the highlight item? Wouldn't it be cleaner/more abstract if we save keywords (`red`, `green`...) - so the change-color-dialog shows always something checked...

> change the color of 'red' to be a non-red color (slight shades of red variation makes more sense but I'm not thinking of a common use case for this)....

I'm not thinking so much about users of external tools, just our internal code - and it feels keywords would allow more future features than harcoded color codes - ie...

(I like the separation, in the spirit of what we have: ReaderHighlight only knows/stores/uses keywords - ReaderView, doing the drawing, maps them to colors :))

Let's limit the color madness to highlights. Let's not have it leak too much to our UI widgets. (If there's one that could maybe get it, it's FrameContainer for some...

^ The colored-backgrounds one looks indeed nice. > Don't you see the trend? The color is spreading on eink. Not only on eInk. Android phones and tablets will get it...

There is currently no check for that - fortunately, books don't often change :) The user is expected to long-press on it and "Refresh cached book info". Didn't feel/thought if...