poire-z

(I have no real undestanding of all these licences and legal matters - and no real interest in understanding all that better :) I just want all of us to...

Looks quite innofensive to me. I haven't looked a the code around, but the only situation that could feel it needs a test is with a file with empty content...

> `TRACE ZIP entry 'META-INF/container.xml' unpSz=266, pSz=188` That was with an empty `META-INF/container.xml` ? So, unpSz is not the size of the file content, but the size of the zip...

OK, I don't want to put my head in the specs, so trusting you that your small fix is sane with various combinations of packSize / unpSize when only one...

> Perhaps this could be a place to discuss a more general solution. (Too many questions that make my head hurts :) Anyway, the current behaviour feels good enough to...

It is supported (there might be a few caveats with inheritance, but they shouldn't trigger in the case of this book) https://github.com/koreader/koreader/issues/5821#issuecomment-600225376 The issue with this book is that our...

@virxkane : I'm working on this CSS parsing issue (https://github.com/buggins/coolreader/issues/294#issuecomment-847877805) - so you don't need to (seeing you're browsing all the issues here, you might get the idea to go...

Well, I can't find out how to reproduce it. I can't find out how logically this can happen: ```c // In AutoOpenClosePop(tag_id) // assuming tag_id != "body" if ( tag_id...

> Anyway, this patch might help avoiding going again in the first section of AutoOpenClosePop() that would give the possibility of this loop: Made this patch into https://github.com/koreader/crengine/pull/379

No idea. Can't see where it would crash, and can't reproduce a crash by tweaking the src= in some toc.ncx (making it wrong, empty, stop after the #...) ```xml 2.3...