kicad-footprint-generator icon indicating copy to clipboard operation
kicad-footprint-generator copied to clipboard

Adding Infineon_PG-DSO-8-59

Open eeyrjmr opened this issue 5 years ago • 9 comments

Request to merge config for Infineon_PG-DSO-8-59

eeyrjmr avatar Apr 01 '19 18:04 eeyrjmr

Code Climate has analyzed commit 14d46f7f and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Apr 01 '19 18:04 codeclimate[bot]

@eeyrjmr I don't see that this is an industry-standard package, although it could be, so I'm OK making it Infineon-specific.

We try to use the dimensions exactly as shown on the datasheet, and in exactly the same form. The script will handle any calculations and it makes verification easier. I didn't try this myself, but use the comments I wrote above as a guide to capture the numbers from the datasheet and see if it works. I think most, if not all, will be good.

evanshultz avatar Apr 01 '19 23:04 evanshultz

done, this is closer to the recomended. I am still trying to figure out the options each footprint could take.

It is unfortunate that IR/Infineon failed to follow the SOIC-8W outline (same with their others) but this is their prerogative. Only reason I am submitting is there are other PG-DSO footprints on the system, otherwise I would keep this local (like my Econo3 IGBT module symbol)

eeyrjmr avatar Apr 02 '19 00:04 eeyrjmr

For ease of checking. https://www.infineon.com/cms/en/product/packages/PG-DSO/PG-DSO-8-59/

evanshultz avatar Apr 02 '19 15:04 evanshultz

done. Apologies for the delay... real world stuff..

NOTE: the generate script no longer runs on Gentoo-linux

py ipc_gullwing_generator.py size_definitions/eqfp.yaml 
Traceback (most recent call last):
  File "ipc_gullwing_generator.py", line 590, in <module>
    configuration = yaml.load(config_stream)
  File "/usr/lib64/python3.6/site-packages/yaml/__init__.py", line 109, in load
    raise RuntimeError("Unsafe load() call disabled by Gentoo. See bug #659348")
RuntimeError: Unsafe load() call disabled by Gentoo. See bug #659348

eeyrjmr avatar Apr 22 '19 16:04 eeyrjmr

I think this error should be fixed now by using safe_load(). Hopefully. See https://github.com/pointhi/kicad-footprint-generator/pull/342. You may need to merge MASTER into your PR.

If the tolerance is symmetrical please leave it as a single number and not a list. Otherwise looks good!

evanshultz avatar Apr 26 '19 20:04 evanshultz

If the tolerance is symmetrical please leave it as a single number and not a list. Otherwise looks good!

I have also added a string style where one can give dimensions as parameter_name: nominal +tolp -tolm

parameter_name: nominal +tolp -tolm
parameter_name: nominal +/-tolerance
parameter_name: minimal .. maximal
parameter_name: minimal .. nominal .. maximal

poeschlr avatar May 30 '19 16:05 poeschlr

@eeyrjmr did you ever get around to export the fixed footprint and update the footprint pull request?

poeschlr avatar Sep 27 '19 18:09 poeschlr

@eeyrjmr This all looks good to me. Can you re-generate the footprint and commit it at https://github.com/KiCad/kicad-footprints/pull/1517 so both PRs can be merged?

evanshultz avatar Oct 01 '20 15:10 evanshultz