swift-snapshot-testing
swift-snapshot-testing copied to clipboard
pointfreeco
added 2022 lineup - new devices (14, 14 Pro, 14 Pro, 14 ProMax)
This PR adds the 14, iPhone14Plus, iPhone14Pro, and iPhone14ProMax devices for snapshot testing.
I took the numbers for the device config from: https://useyourloaf.com/blog/iphone-14-screen-sizes/
I believe the traits should be the same as iPhone 13
It would be great to get this merged to get the new devices! Any idea of what is holding this up? 🤔
Can we get an update on when this change will be merged in and if the plan is to continue to actively maintain this library as there hasn't been any merge to master for about 6 months now.
@stephencelis I see you have merged several other PRs in this repo. Is there a process this PR needs to go through to get merged? Our team is working on updating to the latest devices now and would love to go to iPhone 14 if possible. Thanks!
@mbrandonw / @stephencelis is Point-Free still maintaining this repo?
Hi @tinder-owenthomas, yes we do maintain this repo, and merge pull requests that we think are important. However, this project, more so than any of our others, has parts that need constant updating due to Apple's release schedule, and it's just not feasible to keep up-to-date with it all the time.
For example, even in this PR we think there are potentially some mistakes, such as having forceTouchCapability set to .available even though it seems that 3D touch hasn't been supported on Apple devices for a very long time. And it's probably just copy-pasta from other parts of the library, but keeping track of all of these nitty-gritty details in Apple's ecosystem doesn't really seem like a good responsibility for this library.
Further, we feel that a lot of these little utilities can be implemented outside the library, and probably should be. For example, the contents of the PR can be copy-pasted into any project. It does not require any internals from the library. The fact that we haven't yet merged this PR should not hold anyone up from bringing it into their own projects. And the same is true of almost all of the snapshot strategies that are very difficult to maintain in the face of Apple's ever changing frameworks and bugs.
In the end we'd like to evolve this library into a state where nearly all of the strategies are moved out into separate projects, largely supported by the community, so that all that is left is the core of the snapshotting tools.
Hi @rfodge, we are open to merging it, but there are some potential problems with it currently, such as auditing the usage of forceTouchCapability, and making sure all of the other properties are correct.
But I want to re-iterate that the library does not need to support these devices. The ViewImageConfig type is a public struct with a public initializer. It is just a few fields for describing a few aspects of the view. I think it would be perfectly reasonable for you to define static lets for the few device configurations you support in your project, and to not depend on us keeping a 100% accurate list of devices in this library.
