swift-snapshot-testing icon indicating copy to clipboard operation
swift-snapshot-testing copied to clipboard

Published 20 hours ago • verified publisher icon pointfreeco

Add iPhone 13 devices

Open luispadron opened this issue 2 years ago • 1 comments

Closes #594

This PR adds the iPhone13, iPhone13Pro and iPhone13ProMax devices for snapshot testing and adds a missing iPhone12Pro configuration.

I took the numbers for device config from: https://useyourloaf.com/blog/iphone-13-screen-sizes

I believe the traits should be the same as iPhone 12

luispadron avatar May 18 '22 19:05 luispadron

Thanks for confirming! Now, just need a review from a maintainer (:

luispadron avatar Jun 20 '22 02:06 luispadron

Any chance this gets in soon?

djpearce avatar Aug 30 '22 21:08 djpearce

Thanks for this PR @luispadron! Before maintainers approve this, is there a chance you also squeeze in the iPhone 14 line up? Thanks!

armanarutiunov avatar Sep 12 '22 10:09 armanarutiunov

@armanarutiunov Looks like I didn't see the comment in time sorry about that! Id make a new PR to review those separately

luispadron avatar Sep 21 '22 22:09 luispadron