pointfreeco
Swift concurrency
Update the Library to the new swift-concurrency standard. I was thinking if removing the composable architecture dependency makes sense.
This PR is still in draft because I have to:
- [ ] update documentation
- [x] eventually remove the composable-architecture dependency
Please let me know if this PR is any good!
@rcasula Thanks for looking into this! We definitely have plans to adopt this new style soon, but haven't had time to look into it. This looks good! Just a couple things we need to figure out in the future:
- Does the
managerneed to be protected in an actor? And what concurrency warnings show up when we turn on-Xfrontend -warn-concurrency -Xfrontend -enable-actor-data-race-checks? - We'd probably want to coordinate this change with a library rename. Something like
core-location-clientorcore-location-dependency.
Going to keep this open for now while we find the time to figure out those details. Thanks for getting this work started though!
Hey, what is the status of this PR? What needs to be done to wrap up the new release?
For completeness' sake, following a discussion in this PF's slack thread, to ensure CLLocationManager is accessed from the main RunLoop an alternative solution could be to use a MainActorIsolated structure as introduced here.
It appears to ensure CLLocationManager's APIs are invoked on the Main RunLoop, so it has the benefit of avoiding the Task { @MainActor } and not requiring sprinkling @MainActor in all API closures, making it less verbose and possibly less error prone as well if more APIs are added in the future.
Seems like an interesting approach, but ideally someone with more experience in swift concurrency can chime in, or at least we have one more approach to consider 🤓
@rcasula can this MR be marked as ready for review? What documentation updates are missing? Thanks!