godot-admob-ios icon indicating copy to clipboard operation
godot-admob-ios copied to clipboard

[BUG] RequestConfiguration is set to inappropriate default value

Open abcjjy opened this issue 8 months ago • 2 comments

Godot version

4.2.2

Plugin version

v3.1.1

Phone information

iPhone X iOS 14.8

Issue description

Following values are set to -1 as default in godot scripts. And these values are passed to Admob SDK directly, which causes the personalized ad is disabled and revenue loss. Unspecified values can not be set through this api.

Take Admob Unity plugin as a reference. It converts these values to native constants in ObjC code explicitly.

https://github.com/poingstudios/godot-admob-ios/blob/ba092394c1437cad858c8153a999b5ff20397c10/PoingGodotAdMob/src/ads/PoingGodotAdMob.mm#L53-L54

Steps to reproduce

Use default request configuration to setup.

Additional context

No response

abcjjy avatar Jun 03 '24 12:06 abcjjy