godot-admob-android icon indicating copy to clipboard operation
godot-admob-android copied to clipboard

Add clicked and impression signals to all ad types

Open gianlluca opened this issue 2 years ago • 3 comments

Add clicked and impression signals to Insterstitial, Rewarded and Rewarded Interstitial ad types.

I moved too the Insterstitial setFullscreenContentCallbacks from load_interstitial to show_interstitial method to keep consistency with Rewarded and Rewarded Interstitial that already set fullscreenContentCallbacks on the show methods. Let me know if it's ok.

gianlluca avatar Aug 05 '22 16:08 gianlluca

Thank you for the move of setFullscreenContentCallbacks, i will test it tomorrow and check if everything is running well

gumaciel avatar Aug 10 '22 01:08 gumaciel

@gianlluca I tested here and seems fine, but i'm missing some signals for Banner: https://developers.google.com/admob/android/banner#ad_events

I will try to do this feature for iOS

gumaciel avatar Aug 13 '22 15:08 gumaciel

@gianlluca I tested here and seems fine, but i'm missing some signals for Banner:

Funny cause I didn't change anything on banner methods, I will have to do some tests

gianlluca avatar Aug 13 '22 15:08 gianlluca

Ty merged

gumaciel avatar Sep 29 '22 23:09 gumaciel