phantom-html-to-pdf icon indicating copy to clipboard operation
phantom-html-to-pdf copied to clipboard

Published 20 hours ago • verified publisher icon pofider

Added the ability to pass zoomFactor as an option

Open joemaffei opened this issue 7 years ago • 2 comments

The project I'm working on required me to pass zoomFactor as an option, but phantom-html-to-pdf defaults it to a 1. This tiny modification is a useful addition to this package, given that different versions of phantomjs reportedly yield PDFs with inconsistent scaling.

Don't mind the whitespace changes! :)

joemaffei avatar Jul 13 '17 00:07 joemaffei

I changed one innocent line of code, yet the build is failing miserably. @pofider Does this prevent the pull request from being accepted?

joemaffei avatar Jul 13 '17 00:07 joemaffei

The travis CI just sometimes fails on this package for some reason. Feel free to clone the repo, investigate what we have wrong and send pull request which fix that. :)

I restarted the build and now it is green. So I'm ready to accept it. Just a question before. Does this really allows to run the same html with phantomjs v1 or v2 and the result is the same with just adapting the zoomFactor? I see many issues on phantomjs github which complains the zoomFactor doesn't work. Maybe you could add this to the readme with the particular values which should be set if it really works.

pofider avatar Jul 13 '17 07:07 pofider