Lennart Poettering
Lennart Poettering
lgtm, but needs rebase
looks superficially ok, but please have another look at the coding style: https://systemd.io/CODING_STYLE/#formatting and make sure that the patch matches this and the rest of the code.
this looks pretty good to me. just some minor nits. I'll leave it to @yuwata to do a final review/merge though
btw, please squash your patches into commits that indicate logical steps, but not necessarily historical ones. we want that patches are "perfect", and can be reasonably bisected. or in other...
I'd like to understand better what kind of "lock" you ran into. The error check you are doing here suggests to me that you might have a PIN (aka "authValue")...
> TPM is locked, but I guess I was wrong. Well, "TPM locked" is a bit vague. Could mean "in DA lockout", or could be "requires a PIN to access"...
But if you turn on debug logs, then you should see more info, that might be helpeful
https://lore.kernel.org/all/[email protected]/T/ Judging by this this is really about a PIN (i.e. authValue) having been set for the "owner" hierarchy, and not about DA lockout.
Or in other words you are running into #22129. On what kind of system did you run into with btw? How come a password was set for owner auth there?...
So I think we can merge something like this, but please clean up the wording. I checked the specs btw: while DA lockout mode is on, any attempt to access...