Lennart Poettering

Results 1503 comments of Lennart Poettering

> This is the experiment I am talking about: [bluca@6409152](https://github.com/bluca/systemd/commit/64091520e9faaae51cc475fb7cc4171e0ebb7f9b) and yeah that solves the problem, but I thought it stood no chance tbh no, not like that. the dissection...

one note: there's io.systemd.Import these days, which is a very similar interface but exposed by importd. It will ultimately fork off systemd-pull binary too, but be kind of a middle...

is the mm stuff backing this already available in released kernels?

oh, some of my confusion stems from the fact that the commits are not squashed. please always squash your commits to that the series of commits reflects *logical* changes, but...

So, please clean up the logic here, and document it clearly: can i disable THP globally and reenable it locally? can i enable THP globally and disable locally? if so,...

looks generally ok, but some coding style issues, see above

looks really good, just a bunch more coding style nitpicks

> Thanks for the reviews! I addressed everything apart from set/get_memory_thp in src/basic/process-util.c. I think the functions will be used in only one place, so just kept it in place,...

lgtm if you fix that one `{`

I am not sure I grok what the problem is? By using ACLs we can lock down acecss to things in a much nicer way since we can give specific...