Yinan Xu

Results 201 comments of Yinan Xu

> Can you see if the localize change (#5072) fixes your issue? > I'm sorry but I'm currently off the office because of the public holidays here in China. I...

> Can you see if the localize change (#5072) fixes your issue? I test the option on the XiangShan design generated by Chisel. Prior to the `--localize-max-size` commit, the stack...

`t_stack_check` fails because it does not successfully grep the warning message from output. I'm not sure how this test should expect its standard output after we add the dynamic resizer...

> Realized I suggested the define being 0/1 but think it's better not to have it create a define if we can avoid it. With this I'll merge once passes....

> In fact, I think we should remake our workload infrastructure and documents... There is a lot of things to do. A CI flow to build the workload will benefit...

I just realized the `workload_build_env` repo was probably adapted from the forked opensbi repo (https://github.com/OpenXiangShan/opensbi/tree/github) in OpenXiangShan. It is not a good practice to extract public code into a personal...

For reviewers, please carefully format the squashed commit title/messages when merging this PR. Thanks

This PR is due to some exceptions during VCS simulation. However, the C++ seems to have the same functionality before and after this PR. I'm converting this to draft now....