podverse-rn icon indicating copy to clipboard operation
podverse-rn copied to clipboard

Add "Mark as played" button to player

Open eroc1990 opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like Currently, users need to navigate to the podcast, find the episode, and mark it as played. Ideally, a user could mark it as played while the podcast is playing, which would set the playback progress to 100% and move on to the next item in queue.

Describe alternatives you've considered I know it can be done from the show's episode list page, but that feels clunkier than doing it from in the player.

Additional context N/A

Please feel free to join our Discord and chat with us in the #dev channel if you'd like to work on this.

eroc1990 avatar Aug 03 '22 21:08 eroc1990

@eroc1990 interesting I never thought of using that in the player. We do have a more button on the player though without many options. It'd be pretty easy to add "Mark as played" there :)

mitchdowney avatar Aug 12 '22 02:08 mitchdowney

@mitchdowney that's kind of what I was thinking. It's a good way to bail out of a podcast if you decide you don't want to complete the episode after all but don't want the progress bar to show partial playback. A weird conundrum, I know. But it's that kind of thing that bugs me when I see it on my own library lol.

eroc1990 avatar Aug 12 '22 03:08 eroc1990

@eroc1990 After a discussion with @mitchdowney, we decided to add the button in the player's more actions list, which will mark the episode as played and skip to the next item in the queue, but won't set the progress to the end, because if we marked an episode played manually, we'd like to know where we left off in case we want to re-listen later.

kreonjr avatar Aug 30 '22 05:08 kreonjr

@kreonjr That makes sense. I guess I was just speaking more from the perspective of how I use Mark as Played. Generally if I use it while listening to a podcast, I've made the decision that I've listened to enough of the podcast and am ready to call it finished, thus why my original enhancement request led in with that.

eroc1990 avatar Aug 30 '22 12:08 eroc1990

This should be in v4.6.4.

https://github.com/podverse/podverse-rn/pull/1182

mitchdowney avatar Sep 10 '22 01:09 mitchdowney