pods icon indicating copy to clipboard operation
pods copied to clipboard

Validation timing

Open rmckeel opened this issue 10 years ago • 3 comments

With Pods 2.5 release, I am seeing the pre_save hook called BEFORE validation is completed. I have an email field that is required on an advanced content type (MySQL table storage), as the screenshot shows.

  • If I have nothing filled in that field and click 'Save Student', the pre_save hook for the student pod does NOT trigger.
  • If I have "a@a" filled in that field and click 'Save Student', the pre_save hook DOES fire, and I get a javascript warning and no indication that anything has saved.

A similar thing happens with a field type of 'phone' that is required. If I type in nothing, I get an immediate kick-back with no pre_save hook called. If I type in 'a', I get a validation message but pre_save hook IS called.

This results in inconsistency, and since I use the pre_save hook to trigger actions when the pod may NOT be saved, this could be a real problem. Not sure if this existed in prior versions or not, as I may not have tested it this way before.

Thanks! Pods has overall really helped the project I've been working on, so I appreciate your support.

image

rmckeel avatar Dec 31 '14 22:12 rmckeel

Regression possibly could be related to #2515

Shelob9 avatar Dec 31 '14 22:12 Shelob9

Is this still an active issue? I couldn't reproduce that quickly..

JoryHogeveen avatar Jul 14 '20 16:07 JoryHogeveen

@JoryHogeveen I have no idea. I'm not still working on this project from 6 years ago. Perhaps it was fixed as I imagine pods has undergone lots of revisions since then. I'm fine with this being closed out if you / the community can't reproduce with current Pods.

rmckeel avatar Jul 14 '20 17:07 rmckeel