poco icon indicating copy to clipboard operation
poco copied to clipboard

Poco::Util::Application VxWorks main is incorrect

Open spencerjcoward opened this issue 3 years ago • 4 comments

Describe the bug A clear and concise description of what the bug is.

The POCO_APP_MAIN macro in the Application class resolves to the incorrect version for VxWorks RTPs. The program fails to link, due to the macro using int pocoAppMain(const char* appName, ...) \ version, this is supposed to be used in a kernel context.

To Reproduce Steps to reproduce the behavior. If feasible, please provide a SSCCE - usually, it will make the process much easier and faster.

In order to reproduce, try to compile a simple Poco::Util::Application as an RTP for VxWorks

Expected behavior A clear and concise description of what you expected to happen.

The program compiles and links correctly.

Logs If applicable, add logs to help explain your problem.

N/A

Screenshots If applicable, add screenshots to help explain your problem.

N/A

Please add relevant environment information:

  • OS Type and Version
  • POCO Version
  • Third-party product (eg. database or library) type and version

OS: VxWorks 7 Workbench SR660 POCO: Latest

Additional context Add any other context about the problem here.

spencerjcoward avatar Aug 20 '22 19:08 spencerjcoward

https://github.com/pocoproject/poco/blob/be19dc4a2f30eb97cc9bdd7551460db11cc27353/Util/include/Poco/Util/Application.h#L523

spencerjcoward avatar Aug 20 '22 19:08 spencerjcoward

currently to get this to work something like

#elif defined(POCO_VXWORKS) && !defined(POCO_VXWORKS_RTP)

could solve this issue

spencerjcoward avatar Aug 20 '22 19:08 spencerjcoward

if you need this fixed, please fix and send a pull, we don't have the development or CI environment readily available

aleks-f avatar Aug 21 '22 12:08 aleks-f

if you need this fixed, please fix and send a pull, we don't have the development or CI environment readily available

PR was made.

spencerjcoward avatar Aug 21 '22 17:08 spencerjcoward