poco icon indicating copy to clipboard operation
poco copied to clipboard

Logger translate Notice Level to Information Type on EventLogChannel

Open KevDi opened this issue 4 years ago • 4 comments

I'm currently working with the EventLogChannel, would it not be better to map the Notice Logger Level also to the EventLog Information Type``? Because on a release build the lowest possible level is Information. And i like to use the information level for logging a lot of more informations then the notice level. And from my point of view Notice Logs are not warnings for me. So maybe it would make sense to map also the Notice Level to the Information Type when using the EventLogChannel?.

KevDi avatar Jul 09 '21 07:07 KevDi

This issue is stale because it has been open for 365 days with no activity.

github-actions[bot] avatar Jul 10 '22 03:07 github-actions[bot]

I don't know - notice indicates something out of ordinary, so it fits better into warning then information category. But I don't use this functionality and I also don't fully understand the release/debug build logic - why does windows event log care, and how does it know whether the application is built as debug or release?

aleks-f avatar Jul 10 '22 16:07 aleks-f

@aleks-f There are some Preprocessor Checks in the Logger Code. If the _DEBUG is set (which is the case on Debug Builds on Windows) then logging to Debug is possible. If you build on Release this Preprocessor definition is not there so that logging to debug are not written to any logging output.

KevDi avatar Jul 10 '22 18:07 KevDi

But from your point of view, notice is sometihng out of ordinary, it makes sense that it is mapped to warning instead of information.

KevDi avatar Jul 10 '22 18:07 KevDi

This issue is stale because it has been open for 365 days with no activity.

github-actions[bot] avatar Jul 12 '23 02:07 github-actions[bot]

This issue was closed because it has been inactive for 60 days since being marked as stale.

github-actions[bot] avatar Oct 02 '23 02:10 github-actions[bot]