openssl icon indicating copy to clipboard operation
openssl copied to clipboard

OpenSSL version indication

Open petko opened this issue 7 years ago • 5 comments

It would be handy, if there is some indication in the code or in the Readme, which version (the letter after the 1.1.0) of OpenSSL is used for building the libraries. I know that it is the latest available when the libs are build or that I can build them myself, but it will be just easier for people using it to know if they have the latest sub-release.

petko avatar Apr 10 '18 14:04 petko

The version is whatever the user links with, so putting that information in readme makes no sense.

As for showing the version used, if poco-supplied OpenSSL windows binaries and headers are used, that is already shown during compilation on windows.

If you'd like to see it on other platforms/compilers, send a pull - bear in mind, the main obstacle is portable #pragma message, so whatever you do, it should be properly ifdef'd.

aleks-f avatar Apr 10 '18 14:04 aleks-f

I guess some sort of readme info would make sense for binary distributions @zosrothko

aleks-f avatar Apr 10 '18 14:04 aleks-f

In the NuGet packaging, the poco-1.9.1 is claiming a dependency on the Poco OpenSSL 1.1.0 specificaly packaged for Poco via the NuGet metadata specs.

On the MSI package, nothing is stated right now and a sort of readme should be added one day.

zosrothko avatar Apr 11 '18 19:04 zosrothko

@petko I was commenting here thinking it is a poco issue, sorry. My above comments apply for poco.

As for this build here, I'm not sure what you mean - whatever version you specify on the build.ps1 command line, that's what you get. If you specify only 1.1.0, it will pul the most recent letter-version from that release series and then you can look for OPENSSL_VERSION_TEXT define.

aleks-f avatar Apr 12 '18 19:04 aleks-f

Aleks, I was referring to the version of the already compiled DLLs in the repository's build directory.

petko avatar Apr 13 '18 08:04 petko