PocketSVG icon indicating copy to clipboard operation
PocketSVG copied to clipboard

After the version 2.7.3 update, SVG parsing loses details。

Open CodeForRabbit opened this issue 1 year ago • 6 comments

test I lost some SVG details when I updated the 2.7.3 version, See the code after sure is https://github.com/pocketsvg/PocketSVG/commit/42078d1040cb35b45d9af167ad3aa88d8e69e4f2 the problems after the commit, I deleted this update and everything worked fine.

In addition, I found in use that the framework does not support some tags. Such as:

<defs> </defs>

The contents wrapped in these labels cannot be interpreted, Will these tags be supported in the future?

CodeForRabbit avatar Oct 09 '23 02:10 CodeForRabbit

Other SVG Settings include: fill-rule If no difference is made, the filling effect will be different. The corresponding CALayer also has the fillRule attribute, hoping to add compatibility.

CodeForRabbit avatar Oct 12 '23 04:10 CodeForRabbit

Hello @CodeForRabbit

sorry for the delay.

It looks like the only change after that commit was your PR: https://github.com/pocketsvg/PocketSVG/compare/42078d1040cb35b45d9af167ad3aa88d8e69e4f2...master

This should only have affected colours. What other information is missing?

arielelkin avatar Nov 13 '23 18:11 arielelkin

I want to error from https://github.com/pocketsvg/PocketSVG/commit/42078d1040cb35b45d9af167ad3aa88d8e69e4f2 to submit the while loop line 542 from the beginning. You can test the butterfly svg in my attachment, parsing it will lose some details.

Uploading 1.svg…

CodeForRabbit avatar Nov 14 '23 03:11 CodeForRabbit

What's the error you're referring to?

arielelkin avatar Nov 14 '23 11:11 arielelkin

I confirm, SVG parsing is corrupted in version 2.7.3. IMG_0006

alexacz avatar Jan 16 '24 17:01 alexacz

我确认,SVG 解析在 2.7.3 版中已损坏。 IMG_0006

I changed the line:542~557 of the SVGEngine.mm file back to before and everything worked fine

CodeForRabbit avatar Feb 23 '24 11:02 CodeForRabbit