tshark.dev
tshark.dev copied to clipboard
pocc
--minify breaks svgs
This was recognized as an issue in minify and was fixed in v2.5.1.
Now we just need to wait for it to percolate into hugo versions so that in netlify commands, --minify can be specified.
This was recognized as an issue in minify and was fixed in v2.5.1.
This was actually fixed 5 days after minify v2.5.1 was released, so the version we want is v2.5.2.
As a Hugo contributor, I came across your issue very accidentally, starting with minify before v2.5.1 not building with Go 1.13 in GOPATH mode (for Debian packaging), and then with a failing Hugo minify SVG test due to the fix for https://github.com/tdewolff/minify/issues/260. If it weren't for these two "accidents", we might have never seen this issue at all!
No, dependencies like minify do not percolate into Hugo automatically, and that is how Go modules work by default. After all, "when it ain't broke, don't fix it". So, next time, please do not hesitate to file an issue over at gohugoio/hugo, or we might never see it. Cheers!
Genius! Thanks so much @anthonyfok.
Will close this once hugo has a tagged version that can be pushed to and tested on netlify.