nifty-wallet icon indicating copy to clipboard operation
nifty-wallet copied to clipboard

Ethereum.enable promise is not working when app pass-locked

Open ilanolkies opened this issue 4 years ago • 2 comments

What browser and version did you use?

Chrome latest

What operating system did you use?

Mac OS

Do you have screenshots showing the problem?

Screen Shot 2020-11-12 at 20 29 45

What is your issue?

In the screenshot I try to show 2 different behaviours that work unexpected:

  1. The wallet does not pop up when sending window.ethereum.enable() when the user has not input their password
  2. When building dapps, the Promise gets resolved with unexpected result. This makes dapps working with Metamask have to handle Nifty login in a different manner. I think this does not make sense and the app should pop up and request pass once the developer triggers enable.

ilanolkies avatar Nov 12 '20 23:11 ilanolkies

Duplicate of https://github.com/poanetwork/nifty-wallet/issues/222

vbaranov avatar Nov 13 '20 13:11 vbaranov

It is mor than just UI. Developers expect that promise not to resolve until the flow is finished.

ilanolkies avatar Nov 13 '20 13:11 ilanolkies