hbbft icon indicating copy to clipboard operation
hbbft copied to clipboard

Port all tests to the new framework.

Open afck opened this issue 6 years ago • 8 comments

We have two integration test frameworks at the moment, in tests/net and tests/network. We need to port all the tests to the former, and remove the latter:

  • [x] binary_agreement_mitm.rs
  • [x] binary_agreement.rs
  • [x] broadcast.rs
  • [x] honey_badger.rs
  • [x] net_dynamic_hb.rs
  • [ ] queueing_honey_badger.rs
  • [x] subset.rs
  • [x] threshold_sign.rs
  • ~sync_key_gen.rs (if applicable?)~
  • ~dynamic_honey_badger.rs~

afck avatar Nov 06 '18 16:11 afck

I'm not sure why there are two binary_agreement.rs tests in the list. I'll work on porting BA tests.

vkomenda avatar Nov 12 '18 08:11 vkomenda

Thanks, I removed the duplicate.

afck avatar Nov 12 '18 08:11 afck

I recorded in the checklist that the test of Binary Agreement has been updated in #336.

vkomenda avatar Nov 20 '18 16:11 vkomenda

test_threshold_sign_first_silent_50_samples fails sometimes which may indicate a bias but it's currently non-reproducible because it instantiates the RNG with thread_rng instead of using the proptest TestRng. This bug must be fixed as part of this bigger issue.

vkomenda avatar Mar 14 '19 11:03 vkomenda

test_threshold_sign_first_silent_50_samples is now using TestRng, tolerance increased to 33% as suggested by @vkomenda in the discussions in PR #387.

dforsten avatar Mar 15 '19 10:03 dforsten

sync_key_gen.rs does not use the old network simulator, should probably be taken off the list in this issue.

dforsten avatar Mar 15 '19 10:03 dforsten

dynamic_honey_badger.rs is not present in the test folder any more, should probably be taken off the list in this issue as well.

dforsten avatar Mar 15 '19 10:03 dforsten

PR #389, once merged, will close this issue.

dforsten avatar Mar 18 '19 06:03 dforsten