hbbft
hbbft copied to clipboard
Port all tests to the new framework.
We have two integration test frameworks at the moment, in tests/net
and tests/network
. We need to port all the tests to the former, and remove the latter:
- [x]
binary_agreement_mitm.rs
- [x]
binary_agreement.rs
- [x]
broadcast.rs
- [x]
honey_badger.rs
- [x]
net_dynamic_hb.rs
- [ ]
queueing_honey_badger.rs
- [x]
subset.rs
- [x]
threshold_sign.rs
- ~
sync_key_gen.rs
(if applicable?)~ - ~
dynamic_honey_badger.rs
~
I'm not sure why there are two binary_agreement.rs
tests in the list. I'll work on porting BA tests.
Thanks, I removed the duplicate.
I recorded in the checklist that the test of Binary Agreement has been updated in #336.
test_threshold_sign_first_silent_50_samples
fails sometimes which may indicate a bias but it's currently non-reproducible because it instantiates the RNG with thread_rng
instead of using the proptest TestRng
. This bug must be fixed as part of this bigger issue.
test_threshold_sign_first_silent_50_samples is now using TestRng, tolerance increased to 33% as suggested by @vkomenda in the discussions in PR #387.
sync_key_gen.rs does not use the old network simulator, should probably be taken off the list in this issue.
dynamic_honey_badger.rs is not present in the test folder any more, should probably be taken off the list in this issue as well.
PR #389, once merged, will close this issue.