hydra
hydra copied to clipboard
pnxtech
Consider supporting YAML for hydra configs
I see PR#166 in theory handles this Issue .. but nothing on the PR request has happened??
The issue I raised privately (@taurenk and I work together) is that of adding another dependency. At one point I was on a crusade to slim Hydra (core) in size. My reason was that I wanted us to be able to claim that Hydra is a light-weight library.
I routinely use cost-of-modules to check on size.
$ npm install -g cost-of-modules
/Users/cjustiniano/.nvm/versions/node/v8.9.4/bin/cost-of-modules -> /Users/cjustiniano/.nvm/versions/node/v8.9.4/lib/node_modules/cost-of-modules/lib/index.js
+ [email protected]
added 16 packages in 1.677s
$ cost-of-modules
Making sure dependencies are installed
npm install --production
up to date in 2.044s
Calculating...
┌──────────────┬────────────┬───────┐
│ name │ children │ size │
├──────────────┼────────────┼───────┤
│ bluebird │ 0 │ 0.59M │
├──────────────┼────────────┼───────┤
│ redis │ 3 │ 0.26M │
├──────────────┼────────────┼───────┤
│ redis-url │ 1 │ 0.17M │
├──────────────┼────────────┼───────┤
│ debug │ 1 │ 0.06M │
├──────────────┼────────────┼───────┤
│ route-parser │ 0 │ 0.05M │
├──────────────┼────────────┼───────┤
│ umf │ 0 │ 0.03M │
├──────────────┼────────────┼───────┤
│ uuid │ 0 │ 0.02M │
├──────────────┼────────────┼───────┤
│ 7 modules │ 4 children │ 1.01M │
└──────────────┴────────────┴───────┘
One way to support this might be to build a HydraPlugin (https://github.com/flywheelsports/hydra/blob/master/plugins.md) that adds yaml to json conversion.
The following are examples of HydraPlugins:
- https://github.com/ecwyne/hydra-plugin-rpc
- https://github.com/jkyberneees/hydra-plugin-http
- https://www.npmjs.com/package/hydra-event-bus-plugin
Personally I don't have a "dog in this hunt" as it were -- I'm a TOML fan :) The reason I bring this up though is because for those looking from the outside -- seeing "old" PR requests apparently "ignored" is not a good sign for an Open Source project. The goal should be to merge or reject PR's ASAP .. and not leave them lingering .. But that's my opinion ..