aioresponses icon indicating copy to clipboard operation
aioresponses copied to clipboard

Published 20 hours ago • verified publisher icon pnuckowski

Specify type of `stream_reader_factory`

Open hf-kklein opened this issue 2 years ago • 3 comments

Fixes mypy warning

aioresponses\compat.py:31: error: All conditional function variants must have identical signatures [misc]

hf-kklein avatar Mar 12 '22 10:03 hf-kklein

Codecov Report

Merging #208 (b0786c4) into master (b8393e7) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   95.75%   95.77%   +0.01%     
==========================================
  Files           3        3              
  Lines         283      284       +1     
==========================================
+ Hits          271      272       +1     
  Misses         12       12
Impacted Files Coverage Δ
aioresponses/compat.py 75.60% <100.00%> (+0.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8393e7...b0786c4. Read the comment docs.

codecov-commenter avatar Apr 05 '22 11:04 codecov-commenter

Actually, this whole if statement and two versions of stream_reader_factory are not needed, see #223

marcinsulikowski avatar Oct 19 '22 20:10 marcinsulikowski

You're right. Merging #224 would make this PR obsolete :)

hf-kklein avatar Oct 20 '22 05:10 hf-kklein