action-setup icon indicating copy to clipboard operation
action-setup copied to clipboard

Should upgrade node20 to node24

Open poad opened this issue 2 months ago • 4 comments

On September 19, 2025, it was announced that actions using Node 20 on GitHub runners would be deprecated. Node 24 is scheduled to become the standard Node.js version for GitHub runners on March 4, 2026, and Node 20 is planned to be removed in late summer 2026.

GitHub blog

poad avatar Oct 09 '25 15:10 poad

I completed package installation just with pnpm/action-setup, but need an option to switch Node.js version for matrix testing.

IzumiSy avatar Dec 03 '25 05:12 IzumiSy

@IzumiSy

I completed package installation just with pnpm/action-setup, but need an option to switch Node.js version for matrix testing.

This issue is about changing https://github.com/pnpm/action-setup/blob/41ff72655975bd51cab0327fa583b6e92b6d3061/action.yml#L31-L32 which is not relevant for Node.js matrix testing.

You probably need actions/setup-node.

See the documentation section https://pnpm.io/continuous-integration#github-actions for an example.

MikeMcC399 avatar Dec 03 '25 05:12 MikeMcC399

I see. Even engines.node would not be respected in future plan?

IzumiSy avatar Dec 03 '25 05:12 IzumiSy

@IzumiSy

I see. Even engines.node would not be respected in future plan?

You may need to ask your question in a different place, as this repo is concerned with installing pnpm, not with installing Node.js. Please check the README > Notes document section, which says:


Notes

This action does not setup Node.js for you, use actions/setup-node yourself.

MikeMcC399 avatar Dec 03 '25 06:12 MikeMcC399

It would be great to see some work being done towards updating the action to run under node24 instead of node20. There are 2 more working months until GitHub Actions forces the update in March 2026. It could be that doesn't break the action, but only testing in advance can say for sure.

https://github.com/pnpm/action-setup/blob/1e1c8eafbd745f64b1ef30a7d7ed7965034c486c/action.yml#L39-L40

Also it looks like https://github.com/pnpm/action-setup/blob/master/.github/workflows/test.yaml is only testing on pnpm 9.x, not 10.x, so that is also something to be cross-checked, especially as pnpm 11.x is on its way to being released. (Edit: added as separate issue https://github.com/pnpm/action-setup/issues/200.)

MikeMcC399 avatar Dec 15 '25 15:12 MikeMcC399