vscode-viva icon indicating copy to clipboard operation
vscode-viva copied to clipboard

πŸ’‘ [Feature]: Add Update action to tenant wide extensions management capabilities

Open Adam-it opened this issue 9 months ago β€’ 11 comments

🎯 Aim of the feature

The idea is to allow to update Title, Properties, Web template, List template, Sequence, etc. the same way like it is currently possible by editing the item in the Tenant Wide Extensions list.

We could try to introduce a new Update action which should allow to modify the below:

  • Title
  • Sequence
  • Web template
  • List template
  • Host properties

The extension should show a separate prompt for each of the above properties to be updated best prefield with the current values already present for that tenant wide extension.

πŸ€” Additional remarks or comments

We may open it up and start working on this once the parent issue is ready

Adam-it avatar Apr 03 '25 20:04 Adam-it

@Saurabh7019 based on your feed I created this follow up issue. I wonder if we don't end up with to many Update... kind of actions πŸ€”. Wouldn't it produce less confusion if we combine them somehow. What do you think? @nicodecleyre any feed from your side?

Adam-it avatar Apr 03 '25 21:04 Adam-it

@Saurabh7019 based on your feed I created this follow up issue. I wonder if we don't end up with to many Update... kind of actions πŸ€”. Wouldn't it produce less confusion if we combine them somehow. What do you think? @nicodecleyre any feed from your side?

Good point Adam! Maybe better to merge them into one single action 'modify item'.

Another possibility is to make two seperate options

  • update metadata (sequence, properties)
  • update template (list or webtemplate)

nicodecleyre avatar Apr 03 '25 21:04 nicodecleyre

two seperate options

  • update metadata (sequence, properties)
  • update template (list or webtemplate)

This makes sense. Should we add Rename/Remove as separate actions?

  • Modify metadata
  • Modify template
  • Rename
  • Remove

Saurabh7019 avatar Apr 07 '25 13:04 Saurabh7019

@Saurabh7019, @nicodecleyre let's not forget this is a follow up issue. so if the parent issue will be done we will have remove, enable/disable and update actions already πŸ€”

For sure we may just add the rename action. The question is what should we do with next 4 update actions. Should we add them separately, which is a lot, or combine them with the update action we will already have created based on the parent issueπŸ€”. If we combine how should we go about it? I mean VS code by default does not have any UI to build forms except promoting. Or maybe we could have two update actions like:

  • update properties - this will be created based in parent issue
  • update metadata - which will allow to update sequence, list/web template, host props. And in this case VS code will just show 4 prompts to modify each field.

Or we could create a new custom form using web view, but I wonder if it's not an overkill πŸ€”

Adam-it avatar Apr 08 '25 14:04 Adam-it

@Saurabh7019, @nicodecleyre any thoughts on the last comment πŸ‘†

Adam-it avatar Apr 25 '25 08:04 Adam-it

I like the idea of keeping it simple. The next 4 update actions should be handled as part of the parent issue itself, right? In the parent issue, we already have a main Update action, which will prompt users to select the specific property to update.

Here' how I think we should have:

  • Disable
  • Enable
  • Remove
  • Update
    • Title
    • Sequence
    • Web template
    • List template
    • Host properties

Saurabh7019 avatar Apr 27 '25 19:04 Saurabh7019

I like the idea of keeping it simple. The next 4 update actions should be handled as part of the parent issue itself, right? In the parent issue, we already have a main Update action, which will prompt users to select the specific property to update.

Here' how I think we should have:

  • Disable

  • Enable

  • Remove

  • Update

    • Title
    • Sequence
    • Web template
    • List template
    • Host properties

I like this suggestion. The problem with doing everything at once is that the issues get bigger and therefore rather not taken up by the community. That is why initially I suggested to divide this into two issues. The first one with the initial set of manage capabilities and this one as an enhancement to follow up

Adam-it avatar Apr 27 '25 19:04 Adam-it

Can we move the Update action out of the parent issue and create a separate issue just for that? I agree that it seems a bit bigger but keeping all update related actions in one issue could help in reusing a lot of code and keeping it more organized. what do you think?

Saurabh7019 avatar Apr 28 '25 08:04 Saurabh7019

Can we move the Update action out of the parent issue and create a separate issue just for that? I agree that it seems a bit bigger but keeping all update related actions in one issue could help in reusing a lot of code and keeping it more organized. what do you think?

Good call. Done βœ… I think could open it up and the first issue will allow to add other actions like remove, rename, enable etc. and this issue will focus only on update action

Adam-it avatar Apr 28 '25 13:04 Adam-it

Isn't rename same as Update - Title?

Saurabh7019 avatar Apr 29 '25 08:04 Saurabh7019

Isn't rename same as Update - Title?

good comment. It will be the same. I removed the rename from the parent issue and left it as part of this issue so part of the update action

Adam-it avatar Apr 29 '25 10:04 Adam-it

merged to dev and we are planning a new minor shortly. I will do a pre-release shortly

Adam-it avatar Aug 13 '25 00:08 Adam-it