pnp
Adding possibility to add custom additional step
🎯 Aim
This PR implements functionality that allows for custom NPM packages to be installed as part of the scaffolding project setup.
📷 Result
✅ What was done
clarify what was done and what still needs to be finished ex. [Remove this line]
- [X] Added new extension setting for custom steps
- [X] Added custom toggle to activate the
- [X] Added logic to iterate over extension setting value json array and object(s)
- [X] Added notice on how to access the setting
🔗 Related issue
each PR should be linked with a related issue [Remove this line]
Closes: #217
Hi @Adam-it . Thank you for this feedback. When I read the initial issue, I did not understand that there would be a toggle for each individual item defined in the JSON. It makes sense though but that wasn't what I was working towards. However, while implementing what I have so far, I did think about how we could define a group of items for each project type which as you said we can put off for now. Also, I did some research on how to verify the json entered into the setting value. I tried a few different things but it always returned invalid while a valid example was present. I am working on all this now.
Hi @Adam-it . I am having a problem retrieving the setting value on the scaffolding form. I tried getting the nodeVersionManager setting value and showing that in a text field. In doing the same for the customSteps setting I created, I don't get the value.
Hi @Adam-it . I am having a problem retrieving the setting value on the scaffolding form. I tried getting the nodeVersionManager setting value and showing that in a text field. In doing the same for the customSteps setting I created, I don't get the value.
do you have some commit or branch on which you work where I may check the code?
Here it is. I also realize a problem with how I created this branch.
thanks I will try to have a look as soon as I catch up a bit
@ervingayle I took a look at your changes and actually when I console.log'ed the customSteps variable I did get the setting value coming from VS Code in the WebView
The problem was actually how did you set the value of customSteps. If I did the following changes
I got the expected behavior you are trying to reach
Please let me know if that helped and got you unblocked. 👍
Happy Coding!
@ervingayle did you see my last comment? did any of my tips got you unblocked?
Hello @Adam-it. I did see your comment. Thank you for providing that. I tried it and it works. I am stuck on another part of the implementation to collect the list of items where a toggle is set to true. I am going to work on this as I would like to get this out.
@ervingayle we just had a new minor release. As part of this process we align dev with main. Please rebase your dev branch to align with the current state of dev branch before we proceed on this PR 🙏
@ervingayle are you still working on this change? Is there anything we could help with to get you unblocked?
Hello @Adam-it . I am still working on it. I realize it has been some time but I would like to complete this one. I was stuck on the iteration in the setting and passing those to when the project is created. Thank you for the prior comment, I will make sure the branch is also updated to reflect the recent release.
Hello @Adam-it . I am still working on it. I realize it has been some time but I would like to complete this one. I was stuck on the iteration in the setting and passing those to when the project is created. Thank you for the prior comment, I will make sure the branch is also updated to reflect the recent release.
Thanks for the update 👍
@ervingayle we just had another minor release due to SPFx version update. May I kindly ask you to rebase your branch before we proceed
@ervingayle we just had a new minor release and as part of our release process we needed to rebase the dev branch
Please rebase your branch in order to align the changes
@ervingayle I am closing this one as it has been stale since April and since then a lot have already changed and would require a lot of rebase to catch up. Also we are planning to refactor SPFx Toolkit to support all version of SPFx and due to this the current shape of the scaffolding form will change significantly, which will make this PR and the related issue obsolete. That being said if you plan on getting back to this feature we may always kick of with a new PR or reopen this one if needed, just let us know how you want to proceed. Thanks once again for taking the time and interest in helping us out 👍 You Rock 🤩