sp-dev-fx-webparts
sp-dev-fx-webparts copied to clipboard
pnp
Sample Missing from Adoption Sample Solution Gallery Under My Contributions
Disclaimer
Yes
Sample
https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-accordion
Contributor(s)
gautamdsheth, Abhishek Garg, Sandeep-FED
Question
I’m one of the contributors to this repository, but I noticed that the sample I contributed isn’t appearing under my name in the Adoption Sample Solution Gallery
Is there an additional step I need to take for it to show up—like updating the assets/sample.json file? If so, am I allowed to open a PR for that update?
Please help me on this.
Thanks for bringing this to my attention. It looks like the schema for the sample.json (which is what we use as the sample manifest) may have changed behind the scenes. I'll investigate this.
@PaoloPia can you think of anything that would prevent this sample from appearing?
The sample.json file looks good to me and I even tested it with the validation REST API and it is valid. Can you share a link to the PR that is failing, so that I can try to investigate the issue. Thanks!
The contribution was done last year @PaoloPia, and I missed to add my details in sample.json thats why Im asking for raising an PR to address this issue.
Well, if that is the case, you can simply fix the sample.json file adding your account to the list of authors (here: https://github.com/pnp/sp-dev-fx-webparts/blob/main/samples/react-accordion/assets/sample.json#L38).
@hugoabernier, Just a heads-up — I’ve noticed an issue in the sample.json file under the assets folder regarding the authors property.
Currently, the gitHubAccount field holds the full URL, like this for some of the samples:
"gitHubAccount": "https://github.com/Sandeep-FED",
But on the Sample Solution Gallery, when you click on the avatar for the sample (e.g., react-engage-hub), it results in a Bad Request. After a bit of digging, it seems the gallery expects just the GitHub username (not the full URL), like this:
"gitHubAccount": "Sandeep-FED"
Once I changed that, the redirect worked perfectly. 🎯 This issue also affects two of my other samples, so I’ll go ahead and raise a PR to correct them.
Also, just wondering is the sample.json generated manually or as part of an automated process? Would be good to know in case we want to avoid this kind of mismatch going forward.
good day @hugoabernier , this might be related, i do not see any webparts past 2024 march, something is incorrect with schema also latest framework listed is 1.17. I am using this link: https://pnp.github.io/sp-dev-fx-webparts/
