sp-dev-fx-webparts icon indicating copy to clipboard operation
sp-dev-fx-webparts copied to clipboard

`react-directory` card hover and click no longer works

Open tamerlein opened this issue 2 years ago • 5 comments

Disclaimer

Yes

Sample

react-directory

Author(s)

@joaojmendes

What happened?

react-directory. Hover over and clicking personas no longer does anything. Tested on multiple tenants, no console log error apart from "IDLE cookie missing", which seems to be unrelated to this issue.

Steps to reproduce

  1. gulp build
  2. gulp bundle --ship
  3. gulp package-solution --ship
  4. deploy sppkg
  5. any card does not hover now, clicking also does not bring up modal

Expected behavior

On hover over a profile (persona) , details should expand into a persona card. On click of a profile, a modal should appear with the details of the person and contact info.

Target SharePoint environment

SharePoint Online

Developer environment

Windows

Browsers

  • [ ] Internet Explorer
  • [X] Microsoft Edge
  • [X] Google Chrome
  • [ ] FireFox
  • [ ] Safari
  • [ ] mobile (iOS/iPadOS)
  • [ ] mobile (Android)
  • [ ] not applicable
  • [ ] other (enter in the "Additional environment details" area below)

Paste the results of SPFx doctor

builds fine, error in deployment

Additional environment details

node 10.x

tamerlein avatar Jun 29 '22 03:06 tamerlein

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Jun 29 '22 03:06 ghost

Even I have tried on many tenants but it's not working.

Jitenparmar avatar Jun 29 '22 11:06 Jitenparmar

I can resolve this.

Jitenparmar avatar Jun 30 '22 07:06 Jitenparmar

@Jitenparmar how did you resolve this?

brannmar avatar Jul 01 '22 10:07 brannmar

Microsoft has changed the internal property of the Live Persona card in our code Initially we had a property upn which is now changed to legacyUpn.

image

Reference link: https://github.com/pnp/sp-dev-fx-controls-react/issues/1241

Jitenparmar avatar Jul 01 '22 18:07 Jitenparmar

Thanks, @Jitenparmar can you are absolutely right, thanks for digging it out

I tested it and it was working with the old Property (upn)

But from the description, it should be legacyUpn I added it to RP #3040.

petkir avatar Oct 04 '22 19:10 petkir

Thanks!

//Johan


Från: Marc D Anderson @.> Skickat: Friday, July 1, 2022 8:51:01 PM Till: pnp/sp-dev-fx-webparts @.> Kopia: Johan Brännmar @.>; Comment @.> Ämne: Re: [pnp/sp-dev-fx-webparts] react-directory card hover and click no longer works (Issue #2801)

Also see: pnp/sp-dev-fx-controls-react#1241 (comment)https://github.com/pnp/sp-dev-fx-controls-react/issues/1241#issuecomment-1164231797

— Reply to this email directly, view it on GitHubhttps://github.com/pnp/sp-dev-fx-webparts/issues/2801#issuecomment-1172624971, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB4ZNRANIVHG3R3QRU6NPQTVR44ZLANCNFSM52EHMM3A. You are receiving this because you commented.Message ID: @.***>

brannmar avatar Oct 11 '22 07:10 brannmar

This issue has been marked as stale due to no progress in over 90 days. If you are still experiencing this issue, please provide additional information so we can help you resolve it.

github-actions[bot] avatar Jan 10 '23 02:01 github-actions[bot]

Closing this issue due to lack of activity. If you are still encountering this issue, please do not hesitate to open a new issue. Make sure to follow the guidance on how to create good issues to increase your chances of getting the help you deserve.

github-actions[bot] avatar Jan 18 '23 02:01 github-actions[bot]