sp-dev-fx-vs-extension icon indicating copy to clipboard operation
sp-dev-fx-vs-extension copied to clipboard

package-solution.json incorrect data types

Open ehalsey opened this issue 5 years ago • 2 comments

Category

[ ] Question [x] Bug [ ] Enhancement

Versions

[2019 v16.4.5] Visual Studio version (Help > About) [ @microsoft/[email protected] ] SPFx Generator version (npm list -g @microsoft/generator-sharepoint)

Expected or Desired Behavior

Expect that the "skipFeatureDeployment" and "isDomainIsolated" properties values are generated as boolean in \config\package-solution.json.

Observed Behavior

Property values are generated as strings.

Steps to Reproduce

Create a new spfx proj with defaults and F5.

2020-03-04_16-16-17

Love this extension and as a 20 year SP dev am really starting to take a liking to SPFx and PnP. Thanks!

ehalsey avatar Mar 05 '20 00:03 ehalsey

This is an issue with the underlying command-line operations in the yeoman generator provided by Microsoft. We have added explanatory text in the UI to this effect since there is nothing we can do on our side to fix it. An issue has been open with the SPFx team for over a year but so far no fixes have been forthcoming from Microsoft. Our apologies, but until they address the defect we can’t do anything more.

Eric Shupps BinaryWave T: 888.387.1197 E: [email protected] W: www.binarywave.com


From: Eric Halsey [email protected] Sent: Wednesday, March 4, 2020 6:11:02 PM To: SharePoint/sp-dev-fx-vs-extension [email protected] Cc: Subscribed [email protected] Subject: [SharePoint/sp-dev-fx-vs-extension] package-solution.json incorrect data types (#43)

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.

Category

[ ] Question [x] Bug [ ] Enhancement

Versions

[2019 v16.4.5] Visual Studio version (Help > About) [ @microsoft/[email protected] ] SPFx Generator version (npm list -g @microsoft/generator-sharepoint)

Expected or Desired Behavior

Expect that the "skipFeatureDeployment" and "isDomainIsolated" properties values are generated as boolean.

Observed Behavior

Property values are generated as strings.

Steps to Reproduce

Create a new spfx proj with defaults and F5.

Love this extension and as a 20 year SP dev am really starting to take a liking to SPFx and PnP. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-vs-extension/issues/43?email_source=notifications&email_token=AC5BEZB3BSMHF3C23W2FVILRF3UZNA5CNFSM4LB6U4B2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ISTSKGQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC5BEZE4Q4OUJNEXKJ563N3RF3UZNANCNFSM4LB6U4BQ.

eshupps avatar Mar 05 '20 13:03 eshupps

Understood. Thanks for the follow up.

Thanks, Eric F. Halsey MCP, MCTS| [email protected] | mobile (657) 845-0703 1513949397317_PastedImage A CTO, LLC | 16292 Arlington Ln, Huntington Beach, CA 92649 IM [email protected] | fax 928-244-1024 Bridge 605-475-4350 Access Code: 225-560


From: eshupps [email protected] Sent: Thursday, March 5, 2020 5:36:40 AM To: SharePoint/sp-dev-fx-vs-extension [email protected] Cc: Eric Halsey [email protected]; Author [email protected] Subject: Re: [SharePoint/sp-dev-fx-vs-extension] package-solution.json incorrect data types (#43)

This is an issue with the underlying command-line operations in the yeoman generator provided by Microsoft. We have added explanatory text in the UI to this effect since there is nothing we can do on our side to fix it. An issue has been open with the SPFx team for over a year but so far no fixes have been forthcoming from Microsoft. Our apologies, but until they address the defect we can’t do anything more.

Eric Shupps BinaryWave T: 888.387.1197 E: [email protected] W: www.binarywave.com


From: Eric Halsey [email protected] Sent: Wednesday, March 4, 2020 6:11:02 PM To: SharePoint/sp-dev-fx-vs-extension [email protected] Cc: Subscribed [email protected] Subject: [SharePoint/sp-dev-fx-vs-extension] package-solution.json incorrect data types (#43)

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.

Category

[ ] Question [x] Bug [ ] Enhancement

Versions

[2019 v16.4.5] Visual Studio version (Help > About) [ @microsoft/[email protected] ] SPFx Generator version (npm list -g @microsoft/generator-sharepoint)

Expected or Desired Behavior

Expect that the "skipFeatureDeployment" and "isDomainIsolated" properties values are generated as boolean.

Observed Behavior

Property values are generated as strings.

Steps to Reproduce

Create a new spfx proj with defaults and F5.

Love this extension and as a 20 year SP dev am really starting to take a liking to SPFx and PnP. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-vs-extension/issues/43?email_source=notifications&email_token=AC5BEZB3BSMHF3C23W2FVILRF3UZNA5CNFSM4LB6U4B2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ISTSKGQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC5BEZE4Q4OUJNEXKJ563N3RF3UZNANCNFSM4LB6U4BQ.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/SharePoint/sp-dev-fx-vs-extension/issues/43?email_source=notifications&email_token=ADRV55HJ4EYOV7UT57KMH23RF6TGRA5CNFSM4LB6U4B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN5ITEY#issuecomment-595233171, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADRV55F4K5Y76FTCD3XEXHLRF6TGRANCNFSM4LB6U4BQ.

ehalsey avatar Mar 05 '20 17:03 ehalsey