sp-dev-fx-property-controls icon indicating copy to clipboard operation
sp-dev-fx-property-controls copied to clipboard

index.ts does not export all controls

Open pschaeflein opened this issue 2 years ago • 2 comments

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

  • [ ] Enhancement
  • [X] Bug
  • [ ] Question

Version

Please specify what version of the library you are using: [ 3.10 ]

Expected / Desired Behavior / Question

I expect to import PropertyFieldMessage from '@pnp/spfx-property-controls'

Observed Behavior

I need to import PropertyFieldMessage from '@pnp/spfx-property-controls**/lib/PropertyFieldMessage**';

Discussion

I'm happy to submit a PR, but wondering if this is/was an intentional choice to exclude some controls from the top-level export.

pschaeflein avatar Oct 06 '22 14:10 pschaeflein

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Oct 06 '22 14:10 ghost

@pschaeflein many thanks for this, I just pushed a commit to dev to export this specific control, so this should be in the beta release in a few minutes. We will need to review the other controls as there seem to be a few of them missing...feel free to send a PR if you get the chance :)

joelfmrodrigues avatar Feb 26 '23 23:02 joelfmrodrigues