sp-dev-fx-property-controls icon indicating copy to clipboard operation
sp-dev-fx-property-controls copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Arabic locale file

Open JeanNetryValere opened this issue 2 years ago • 9 comments

Q A
Bug fix? [ ]
New feature? [X ]
New sample? [ ]
Related issues? #461

What's in this Pull Request?

Adding Arabic translation support.

JeanNetryValere avatar Jun 22 '22 07:06 JeanNetryValere

@milanholemans Done here

JeanNetryValere avatar Jun 22 '22 07:06 JeanNetryValere

That's better! ☺️ Don't forget to reference your issue #461 in the description of this PR. Then it should be all good!

milanholemans avatar Jun 22 '22 07:06 milanholemans

@JeanNetryValere many thanks for the PR. Great addition. Unfortunately, I don't know a single word of Arabic 🙂 so I have reached out for help on Twitter to see if someone is available to review as it's always good to have someone reviewing changes. If no one volunteers to help, I will just approve it 🙂

joelfmrodrigues avatar Jun 23 '22 20:06 joelfmrodrigues

@milanholemans many many thanks for your support on this issue and PR. We have been all super busy with work and having other people stepping in to help is fantastic! GoodJobYouRockGIF

joelfmrodrigues avatar Jun 23 '22 20:06 joelfmrodrigues

@JeanNetryValere I asked for help to review the PR on Twitter and @mohammadamer came to the rescue 🙂 Do you agree with the suggestions? If so, could you please update the PR? If not, could you please comment in the relevant message thread? Just trying to capture input from more than one person, hope this is Ok with you.

joelfmrodrigues avatar Jun 27 '22 08:06 joelfmrodrigues

Hello @joelfmrodrigues, Yes perfect, it has been reviewed by my team also. Thank you @mohammadamer

JeanNetryValere avatar Jul 04 '22 11:07 JeanNetryValere

@joelfmrodrigues review submitted Please let me now if closing PR is required

JeanNetryValere avatar Jul 04 '22 12:07 JeanNetryValere

Hi @JeanNetryValere Sorry that I'm making this comment so late, but commenting "changes accepted" is unfortunately not enough. 😃 What you should do now is review all changes of Mohammad and make these changes in your code (be sure to target the same branch as this PR so your master branch). When you made these adjustments in your code, simply do a new commit to this branch. The PR will update and we'll be able to see the new code. When the new code is fine, the maintainers of this repo will accept the PR and close it, so you shouldn't close the PR yourself.

If you have any questions, just ask.

milanholemans avatar Jul 30 '22 21:07 milanholemans

@milanholemans many thanks for the info provided. @JeanNetryValere does the info provided from Milan make sense? Do you have any questions or need assistance with something?

joelfmrodrigues avatar Aug 10 '22 09:08 joelfmrodrigues

Hello @JeanNetryValere - following up on this one. Have you made the proposed changes?

Thanks!

AJIXuMuK avatar Sep 20 '22 00:09 AJIXuMuK

Hello @JeanNetryValere - following up on this one. Have you made the proposed changes?

Thanks!

I did, please revert to me if required. Have fun on merge :)

JeanNetryValere avatar Sep 22 '22 09:09 JeanNetryValere

Thank you @JeanNetryValere for the confirmation!

AJIXuMuK avatar Sep 24 '22 15:09 AJIXuMuK