sp-dev-fx-property-controls icon indicating copy to clipboard operation
sp-dev-fx-property-controls copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Arabic local missing for resource "PropertyControlStrings"

Open JeanNetryValere opened this issue 2 years ago • 4 comments

Hello,

it appears that the localization data is missing for Arabic language. Is this possible to have or plan it in next release please ?

Category

  • [x] Enhancement
  • [x] Bug
  • [ ] Question

Version

version of the library: [3.6.0]

Expected / Desired Behavior / Question

ar-sa.js shipped in package -> dist folder

Observed Behavior

Error - [webpack] 'dist': The selected locale (ar-sa) is not present in the localized data for resource "PropertyControlStrings".

Steps to Reproduce

In the built solution the src/loc/ar-sa.js ressource file is present then gulp serve --locale=ar-sa

Thanks!

JeanNetryValere avatar Jun 09 '22 13:06 JeanNetryValere

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

msftbot[bot] avatar Jun 09 '22 13:06 msftbot[bot]

Hi @JeanNetryValere

As far as I know, none of the contributors speak Arabic. Adding extra translations is always useful but we will need your help with this one. If you are not familiar with SPFx or GitHub contributing, I can send you a CSV file with all English (or another language) labels. If you can add the Arabic translation next to it, we can put this translation in the project so it will be available in the next release. Let me know if you are willing to do this.

milanholemans avatar Jun 15 '22 11:06 milanholemans

Hello @milanholemans, It is pushed. Let me know if additional steps are required. Bye

JeanNetryValere avatar Jun 21 '22 12:06 JeanNetryValere

Hi @JeanNetryValere, looks good! Now we have to wait for this PR to be reviewed and completed. ☺️

milanholemans avatar Jun 21 '22 12:06 milanholemans