sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Grid layout settings as parameters

Open IRRDC opened this issue 1 year ago • 3 comments

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.18.1]

Expected / Desired Behavior / Question

At the moment these parameters that define the grid layout are stored in GridLayout.module.scss: padding, minWidth, maxWidth, compactThreshold, rowsPerPage. It would be very useful to have them be part of IGridLayoutProps to be able to modify the layout when needed.

IRRDC avatar Jul 11 '24 11:07 IRRDC

Hi @IRRDC,

Nice idea! From what I quickly overviewed, I think we should keep default values (if no prop specified) as designed in the scss file.

Would you like to give a try?

michaelmaillot avatar Jan 29 '25 17:01 michaelmaillot

Hi @michaelmaillot, I'd like to pick this up—could you assign this issue to me?

Ateina avatar Feb 23 '25 15:02 Ateina

Hi @Ateina, it's all yours.

michaelmaillot avatar Feb 23 '25 17:02 michaelmaillot