sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Added choice radio button handling

Open GuidoZam opened this issue 11 months ago • 8 comments

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? fixes #1797

What's in this Pull Request?

Added handling of the choice field when set to radio button instead of dropdown.

GuidoZam avatar Mar 23 '24 18:03 GuidoZam

@GuidoZam many thanks for the improvements. I reviewed it and all seems fine, but I will consider waiting for #1726 to avoid conflicts. If the other PR doesn't move forward quickly, I will then merge this PR first.

joelfmrodrigues avatar May 14 '24 23:05 joelfmrodrigues

Thanks @joelfmrodrigues for the update, I'll wait for the merge 😁

GuidoZam avatar May 15 '24 10:05 GuidoZam

I just wrote the same feature and then I found this :-) Is it going to be included in a release build soon?

IRRDC avatar Jul 02 '24 13:07 IRRDC

@IRRDC I think we're still waiting for the other PR. @joelfmrodrigues do you have any news?

GuidoZam avatar Jul 02 '24 13:07 GuidoZam

@GuidoZam hi, sorry I have been struggling to find time and was a bit away from things for personal reasons. Hope to get moving again soon

joelfmrodrigues avatar Jul 02 '24 15:07 joelfmrodrigues

Hope everything's fine @joelfmrodrigues! I didn't want to rush you, I was just checking 😉

GuidoZam avatar Jul 02 '24 16:07 GuidoZam

@GuidoZam I tested your code and would suggest that you remove these two lines: Zwischenablage04 since they lead to duplicate labels and make the field always required. Before removing them: Zwischenablage013 After removing them: Zwischenablage02

IRRDC avatar Jul 03 '24 06:07 IRRDC

Thanks for the feedback @IRRDC!! I've updated the code.

GuidoZam avatar Jul 03 '24 07:07 GuidoZam