sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Fix for #1775 and #1760

Open wuxiaojun514 opened this issue 1 year ago • 4 comments

Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1775 #1760

What's in this Pull Request?

This pull request is to fix two issues on required field validation issues in Dynamic Form control Dynamic Form has done huge refactoring on version 3.17. See pull request 1672 for detail

The root cause of issue #1760 is due to the initial value of newValue has been changed from "null" to "undefined". So I modified the related code to "undefined" as well.

Regarding #1775 , now changedValue won't use loaded item's value as initial value. So I added another check to compare with value when there is no new value on this field.

wuxiaojun514 avatar Feb 27 '24 04:02 wuxiaojun514

@wuxiaojun514

Thanks for taking care of this issue!!!

6gal6ler6 avatar Feb 28 '24 22:02 6gal6ler6

When will be this fix available? When we will have a new release?

devspfx avatar Mar 25 '24 19:03 devspfx

Waiting for #1726

joelfmrodrigues avatar May 14 '24 23:05 joelfmrodrigues

@joelfmrodrigues any news about this issue? We hope to have a resolution

devspfx avatar Aug 28 '24 07:08 devspfx