sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Dynamic form loading error in other site

Open IRRDC opened this issue 1 year ago • 5 comments

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.17.0]

Expected / Desired Behavior / Question

After updating to 3.17.0: When displaying the dynamic form for a list or library in a different site using webAsboluteUrl the form doesn't load but displays the error "An error occurred while loading: Cannot read properties of undefined (reading 'filter')" instead.

IRRDC avatar Feb 07 '24 07:02 IRRDC

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Feb 07 '24 07:02 ghost

I found the problem and created a fix for it https://github.com/pnp/sp-dev-fx-controls-react/commit/45050da4624a1d7fdcc7f3f4499db15d6b4bd346 but I guess I have to do another fork or undo my previous fixes changes to create a separate PR.

IRRDC avatar Feb 08 '24 08:02 IRRDC

Hi @IRRDC , would a new branch not work in this case? I assume you are already working on a fork of the original repo so a new branch should be fine. Or am I missing something?

joelfmrodrigues avatar Feb 08 '24 09:02 joelfmrodrigues

Could this fix be released as a minor version since the problem blocks all use of the dynamic form in scenarios that span sites?

IRRDC avatar Feb 16 '24 05:02 IRRDC

@IRRDC your fix has been merged, thanks! But I am unable to confirm a release date at the moment. Hoping we can get some time for a release soon.

joelfmrodrigues avatar Mar 04 '24 22:03 joelfmrodrigues