sp-dev-fx-controls-react
sp-dev-fx-controls-react copied to clipboard
pnp
Fix #1721
| Q | A |
|---|---|
| Bug fix? | [ ] |
| New feature? | [ ] |
| New sample? | [x] |
| Related issues? | fixes #X, partially #Y, mentioned in #Z |
What's in this Pull Request?
This PR will fix #1721
Guidance
- You can delete this section when you are submitting the pull request.
- Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
- Please target your PR to dev branch.
Hi @nsoeth,
Thanks for this PR!
Regarding the addition of $top query operation, I'd suggest to make it available as optional because it depends on use case and maybe it would not fit for everyone to load 5000 items at once.
Since the DynamicForm lookup field relies on ListItemPicker control, and in order to be available as a field override prop for the DynamicForm, here are the different files to update according to me:
- SPService.ts
- IListItemPieckerProps
- ListItemPicker (
ListItemPickercontrol doc will have to be updated as there will be a new prop available) - IDynamicFieldProps
- DynamicField
Like this, the developer will be free to set the number of items he wants to get 🙂
A suggestion of prop name could be itemsQueryCountLimit or ODataTopCount for example but feel free to suggest!
Let me know if something's not clear or if you need help.
Hi @michaelmaillot , Thanks for your suggestions, I updated the PR.
Kind regards, Niels
Hi @nsoeth,
Are you still working on this one? Do you need any kind of help?
Hi @michaelmaillot Sorry, lot of things to do the last few months but I updated the PR according to your review.