sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Readme documents highlight extension does not work correctly

Open ValerasNarbutas opened this issue 2 years ago • 6 comments

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ ] [Latest] If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Looks like were are breaking symbols in readme files under guides or contributing: https://pnp.github.io/sp-dev-fx-controls-react/guides/contributing/

image

I can work on this one @joaojmendes Just wondering is extension used does not support "sh " and should be "bash"

change this:

# comment

to this:

# comment

In all documents which using "#" for commenting.

Thanks!

ValerasNarbutas avatar Mar 29 '23 12:03 ValerasNarbutas

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Mar 29 '23 12:03 ghost

Thank you for submitting your first issue to this project.

github-actions[bot] avatar Mar 29 '23 12:03 github-actions[bot]

Hi @ValerasNarbutas,

Are you still interested into submitting a PR? 🙂

michaelmaillot avatar Sep 13 '23 00:09 michaelmaillot

Hey, Sure @michaelmaillot, i can do it

ValerasNarbutas avatar Sep 14 '23 08:09 ValerasNarbutas

i did forget this one :) i will check it soon

ValerasNarbutas avatar Dec 13 '23 16:12 ValerasNarbutas

@michaelmaillot added fixes.

ValerasNarbutas avatar Dec 13 '23 16:12 ValerasNarbutas