sp-dev-fx-controls-react icon indicating copy to clipboard operation
sp-dev-fx-controls-react copied to clipboard

Richtext control, can not undo ordered lists

Open tobysroof opened this issue 3 years ago • 6 comments

Category

[ ] Enhancement

[X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.6.0 ]

Expected / Desired Behavior / Question

When using the RichText Component, when selecting a ordered (numbered) list, and then clicking the ordered list control, we expect the numbered list to be unmade. (this works for unordered lists)

Observed Behavior

When selecting a numbered list in a richtext component, and then clicking the numbered list control, the numbered list is unaffected.

Steps to Reproduce

Using the richtext control. Add some lines and then make them into a ordered list by selecting the text and clicking the ordered list option. Click the same option again to "unmake" the list. Note that nothing happens.

Do the same thing with a unordered list and note that the unordered list is "unmade" correctly

tobysroof avatar Feb 21 '22 10:02 tobysroof

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

ghost avatar Feb 21 '22 10:02 ghost

Thank you for submitting your first issue to this project.

github-actions[bot] avatar Feb 21 '22 10:02 github-actions[bot]

Hi @tobysroof many thanks for reporting the issue. Would you be interested in trying to fix it and submit a pull request?

joelfmrodrigues avatar Mar 13 '22 22:03 joelfmrodrigues

Hi @joelfmrodrigues, @michaelmaillot! I think I found the reason for this bug, I can create a PR for it could you assign this issue to me?

Ateina avatar Apr 09 '24 18:04 Ateina

Hi @Ateina,

Sure, it's all yours!

michaelmaillot avatar Apr 17 '24 14:04 michaelmaillot

@michaelmaillot Thank you!

Ateina avatar Apr 17 '24 16:04 Ateina

Linked PR has been merged, the fix should be available in the next beta release.

michaelmaillot avatar Aug 10 '24 00:08 michaelmaillot