powershell icon indicating copy to clipboard operation
powershell copied to clipboard

Script Samples Transfer

Open pkbullock opened this issue 1 year ago • 6 comments

Hi All, putting this issue here as a track of the samples that are moving to script samples as discussed with @gautamdsheth. I will log the PRs and updates here for visibility.

Looking at moving these to Script Samples: https://github.com/pnp/powershell/tree/dev/samples

@gautamdsheth - is there a page that I can update with the new location?

pkbullock avatar Dec 01 '24 08:12 pkbullock

@gautamdsheth - I don't have access to assign tasks, can you do that please? or elevate me to edit issues. Happy either way.

pkbullock avatar Dec 01 '24 08:12 pkbullock

Hey @pkbullock , assigned it to you ! For edit access, maybe you can reach out to Vesa ? Coz even I don't have permission to provide you with edit rights. I dont think we have a dedicated page for these sample scripts, just a readme file in the folder. The samples are themselves quite old and a legacy I guess of the old module.

gautamdsheth avatar Dec 01 '24 19:12 gautamdsheth

Thanks @gautamdsheth i am working through them, see what can be moved and retesting along the way. I have create a page for the docs for the samples and links etc. will ping a PR with the changes to see what you think.

In the meantime, I'll attach the new samples to this issue.

pkbullock avatar Dec 01 '24 20:12 pkbullock

Plans for the folder

Samples to transfer/import:

  • Get Web Parts Audience - concept is good, might modernise.
  • Connect Azure Automation - its one of mine, ill update, i have some variants too.
  • ✅ Find Links In Canvas - will retest and import
  • MetadataViaSiteIdUniqueId - will retest and import
  • Provisioning.CreateSitesFromCSV - will retest and import
  • Provisioning.CreateWithEngine - will retest and import
  • Provisioning.CreateWithPowerShell - will retest and import
  • Provisioning.ModernListLibraryWebPart - will retest and import

Samples to retire

  • Deactivate.Feature - its on-prem/classic focused
  • Modules.Install - script was for module import, on old library
  • SharePoint.ConnectUsingAppPermissions - this is in the docs already, not need for a sample now.
  • Provisioning.SelfHostedWithAzureWebJob - there is an Azure Functions equiv, will consider for retirement

pkbullock avatar Dec 02 '24 05:12 pkbullock

@pkbullock - sounds awesome, about the samples that we want to retire , should we delete them from here ?

gautamdsheth avatar Dec 02 '24 09:12 gautamdsheth

@gautamdsheth - sure, I can update my fork accordingly.

pkbullock avatar Dec 03 '24 09:12 pkbullock