powerplatform-samples icon indicating copy to clipboard operation
powerplatform-samples copied to clipboard

Granamic UI template

Open shaheerahmadch opened this issue 1 year ago • 10 comments

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues? none

Solution Details

Q A
Solution requires premium license no
Solution uses experimental features (see licensing guidelines) no
Which connectors are used? none
Solution uses on-premises connectors? no
Solution uses custom connectors? no
Layout Tablet

What's in this Pull Request?

This pull request contains my canvas app template named Granamic UI Template. This app contains sample custom components that are built using HTML, CSS and Canvas App OOTB Controls. Screenshot 2023-09-03 093448

shaheerahmadch avatar Sep 25 '23 05:09 shaheerahmadch

@Katerina-Chernevskaya oppened a new pull request after going through your instructions. Hope this is okay.

shaheerahmadch avatar Sep 26 '23 07:09 shaheerahmadch

It's been over two weeks since my submission, Is there a problem that i can fix? Thanks

shaheerahmadch avatar Oct 06 '23 16:10 shaheerahmadch

Hi @shaheerahmadch, Thank you for your contribution and your patience! We truly value your contribution. I'm currently working on reviewing your pull request and will provide feedback or merge it as soon as possible.

Katerina-Chernevskaya avatar Oct 06 '23 16:10 Katerina-Chernevskaya

Thank you so much for your prompt response @Katerina-Chernevskaya. Can you also go through my other 3 pull requests as well? I would Highly appreciate it.

Incident Reporting, Editable Subgrid Chat Canvas App

These are my other 3 pull requests.

Thank you so much

shaheerahmadch avatar Oct 06 '23 16:10 shaheerahmadch

Hello @shaheerahmadch,

Thank you for the submission!

During our review, we encountered an issue: the attempt to create a zip file from the provided source code was unsuccessful, indicating that some components might be missing from the initial preparation. Could you kindly review and update the source code to address this issue?

Also we'd like to ask you to enhance the README file, ensuring it aligns with our template.

Your attention to these matters is greatly appreciated. We look forward to reviewing your updated submission.

Regards, Katerina Chernevskaya

Katerina-Chernevskaya avatar Oct 06 '23 18:10 Katerina-Chernevskaya

I'll take a look at the matter. Thanks for your response ☺️

shaheerahmadch avatar Oct 06 '23 18:10 shaheerahmadch

I tried a lot but i was unable to clone the solution using the following command: pac solution clone --name GranamicUITemplate --outputDirectory sourceode --processCanvasApps

Even tried changing the Environment and creating the app again (Coping & Pasting controls from the original one). But still got this error: image

Then I tried the following command: pac solution clone --name GranamicUITemplate --outputDirectory sourceode

It cloned the solution without any error. I have now updated the solutions and also the source code

Note: The canvas app contains custom components

shaheerahmadch avatar Oct 06 '23 20:10 shaheerahmadch

Hi @shaheerahmadch,

I attempted to build a solution from the source code, but the attempt failed with the following error: image

It seems that in sourcecode\GranamicUITemplate\src\CanvasApps folder you miss src folder.

Could you please check again the source code and update it? I also suggest you to upload source code into sourcecode folder directly without any subfolders like GranamicUITemplate\src. Additionally, make sure to update the branch with the latest changes from the main branch.

Thank you!

Katerina-Chernevskaya avatar Oct 19 '23 16:10 Katerina-Chernevskaya

Hello @Katerina-Chernevskaya, I have updated the source code and the readme file. I have testing on my end by creating a solution from the updated source code and importing the solution in a trial environment. Everything seems perfect on my end. You may check and merge. Thanks

shaheerahmadch avatar Oct 21 '23 07:10 shaheerahmadch

Hi @shaheerahmadch,

Sorry, but the error still reproduced while I tried to compile the source code. Please check that the source code was fully copied. Currently the folder 'src' is missed in the folder 'CanvasApps'. Look at the example of the source code structure of your another sample 'editable subgrid': image

Please check the source code.

Thank you!

Regards, Katerina Chernevskaya

Katerina-Chernevskaya avatar Oct 23 '23 13:10 Katerina-Chernevskaya