powerapps-samples icon indicating copy to clipboard operation
powerapps-samples copied to clipboard

Initial Keyword-Tagging Sample

Open mschuess opened this issue 2 years ago โ€ข 3 comments

We're so eager to add your sample to this repository as soon as possible, but we need all samples follow the same structure. To make sure we process it as soon as possible, make sure to follow these instructions.

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues? no

Solution Details

Q A
Solution requires premium license no
Solution uses experimental features (see licensing guidelines) no
Which connectors are used? SharePoint
Solution uses on-premises connectors? no
Solution uses custom connectors? no
Layout Tablet

What's in this Pull Request?

In this Pull Request is a Canvas App that provides a sample for Keyword Tagging content.

mschuess avatar Jul 20 '22 19:07 mschuess

Thank you @mschuess! We will get this processed ASAP! ๐Ÿคฉ๐Ÿ™๐Ÿป๐Ÿ‘๐Ÿป๐Ÿงก๐Ÿ’œ

PopWarner avatar Jul 25 '22 00:07 PopWarner

Hi @aprildunnam do you also review PRs for Samples?

mschuess avatar Aug 12 '22 18:08 mschuess

Hi @aprildunnam do you also review PRs for Samples?

I do. I was reviewing this one but it doesn't match our standard format. Could you please update the sample so that it contains the following folders: Assets Solution sourcecode

Assets should contain all your image files and related assets. Solution should contain the .msapp file and sourcecode should contain the unpackaged code.

Thanks!

aprildunnam avatar Aug 15 '22 03:08 aprildunnam

Hi @aprildunnam @PopWarner

I have put my code in the folder structure. Note, in the instructions, the solution folder is not discussed.

Now that I have the correct folder structure, do I need to abandon this PR or update this PR? Could you please provide instructions on how to do what I need to do next?

Thanks Matt

mschuess avatar Aug 17 '22 14:08 mschuess

Hi @hugoabernier @LuiseFreese ,

Can you provide me a few instructions to get me across the finish line. I have been waiting for 30 days from the initial submission to the first comment.

Thank you!!! matt @mschuess

mschuess avatar Aug 19 '22 14:08 mschuess

dear @mschuess

Will do my best to help getting this processed. Currently under the weather/sick, but will get back to you on monday.

LuiseFreese avatar Aug 19 '22 14:08 LuiseFreese

Hey there @mschuess - had a look at your files and want to provide some guidance on how to match the pattern this repo requires. (please be assured that I will do my best to improve docs as well so that contributors better understand what needs to be done. )

Your folder Keyword-Tagging needs the following subfolder:

  1. assets (please note the lower case a). In this folder please provide all media that you use (for example screenshots of your app or gifs that walkthrough the app).
  2. solution. In this folder please provide the .msapp file
  3. sourcecode. In this folder please provide the unpackaged code of your app. Currently, this sits directly in tagging-keywords, but will move a level down into a sourcecode folder.

To avoid some confusion: The unpackaged code usually contains a folder called Assets (note the capital A), which has nothing to do the assets folder (note the lower case a, that shall sit under the Keyword-Tagging folder.

Please tag me here if you have any question or if I can help in any way.

Thank you for your patience and for contributing.

LuiseFreese avatar Aug 21 '22 10:08 LuiseFreese

hi @LuiseFreese

I believe I committed my files under the new folder structure. Can you give it a check?

CC @PopWarner

mschuess avatar Aug 22 '22 17:08 mschuess

Dear @mschuess - lets let @aprildunnam review this, as she originally reviewed your contribution. Too many cooks in the kitchen otherwise :-)

LuiseFreese avatar Aug 22 '22 19:08 LuiseFreese