pnpcore icon indicating copy to clipboard operation
pnpcore copied to clipboard

Fix #1562

Open koskila opened this issue 1 year ago • 1 comments

Makes sure EnsurePagesLibrary ensures pages library for sites where "Site Pages" is not activated by activating the feature.

This is to address https://github.com/pnp/powershell/issues/3959

koskila avatar Oct 26 '24 14:10 koskila

@koskila : I would not just change the default behavior here as for example automatically enabling a SitePages library on a classic publishing portal is not the right thing to do in my mind. Can you change the PR like this:

  1. Update the name of the private EnsurePagesLibraryAsync method to EnsurePagesLibraryImplementationAsync
  2. Add a new EnsurePagesLibraryAsync method that calls the EnsurePagesLibraryImplementationAsync + adds your enhancement. This method can be made a public one by updating the IPages interface

This way the internal flow is not changed and we don't automatically create a SitePages library from existing code paths, if someone however wants this behavior then can call the public EnsurePagesLibraryAsync method

jansenbe avatar Nov 18 '24 09:11 jansenbe

Closing per no activity

jansenbe avatar Jun 27 '25 06:06 jansenbe