generator-spfx icon indicating copy to clipboard operation
generator-spfx copied to clipboard

Add support for the Graph Toolkit

Open westerdaled opened this issue 5 years ago • 9 comments

General Information

  • [ ] Usage
  • [ ] Development
  • [ ] Documentation
  • [x] Feature Request

Specific generator

  • [x] Addons
  • [ ] HandlebarsJS

What Version you are running?

  • NodeJS: 10.22
  • NPM: 6.14.6
  • @pnp/spfx: 1.11

Describe your problem

With the amazing support already added to the generator, I thought another good candidate is the graph toolkit . npm install @microsoft/mgt . Other the TypeScript 3.x version, I am not sure what the other pre-reqs for such support.

westerdaled avatar Sep 01 '20 14:09 westerdaled

Thank you Daniel, we are looking into it. The current generator support to have different sets of add-ons base on the project they support. Most likely will only be available on SPO projects.

StfBauer avatar Sep 01 '20 15:09 StfBauer

@westerdaled is it enough to just install the npm package?

StfBauer avatar Sep 02 '20 11:09 StfBauer

Do you mean as a result of an additional user prompt? Then yes, perhaps with any dependency checks.

westerdaled avatar Sep 02 '20 11:09 westerdaled

Just as a prompt and inject and install the dependencies.

StfBauer avatar Sep 02 '20 18:09 StfBauer

👍

westerdaled avatar Sep 02 '20 18:09 westerdaled

@westerdaled it is included in 1.15.1

StfBauer avatar Oct 08 '20 08:10 StfBauer

Ok @StfBauer , as in you have not added the support for the Graph toolkit in release 1.15.1? I am happy to test a pre-release / beta if is included in the next release.

westerdaled avatar Oct 08 '20 13:10 westerdaled

@westerdaled it is out now. 🤦‍♂️ Auto-correction from now to not 👍

StfBauer avatar Oct 08 '20 16:10 StfBauer

Doh, that now makes sense. I better try it out 🤔

westerdaled avatar Oct 08 '20 18:10 westerdaled