cli-microsoft365 Add TypeScript version rule and tests for project doctor. Closes #6716

Pull Request Title Adds rule to validate TypeScript dev dependency version. Closes https://github.com/pnp/cli-microsoft365/issues/6716

Linked Issue Closes https://github.com/pnp/cli-microsoft365/issues/6716

Jun 11 '25 02:06 nirav-raval

Thanks, we'll try to have a look at it ASAP!

Jun 11 '25 06:06 milanholemans

@nirav-raval, seems like your tests are failing, could you have a look, please? If you need any help, don't hesitate to reach out to us.

Jun 11 '25 07:06 milanholemans

@milanholemans Thanks for raising. Checked the test errors in the workflow file, it says node version mismatch. I am using v22.16.0. The contribution guide says to use v20, and the workflow file says to use v22.

Can you guide me on this?

Jun 11 '25 14:06 nirav-raval

We are using v22 for development. The version in the docs is being updated, but that PR still has to be merged yet. Sorry for the inconsistency.

Jun 11 '25 17:06 milanholemans

In this case, would you like me to make any changes on my end?

Jun 11 '25 17:06 nirav-raval

The tests are failing. Are you able to reproduce it locally?

Jun 11 '25 18:06 milanholemans

@milanholemans Do I need to update anything here?

Jun 15 '25 00:06 nirav-raval

Ni thanks @nirav-raval . If the tests are passing, it's fine. We'll try to review it ASAP.

Jun 15 '25 00:06 milanholemans

Seems like the workflow is failing @nirav-raval. Could you take a look at it. Looking at your code again, I was wondering if we could simplify the rule drastically by inheriting from the DependencyRule class just like we do for the @types/webpack-env rule.

Aug 11 '25 20:08 milanholemans

@milanholemans Updated the rule based on @types/webpack-env and tests as well.

Aug 16 '25 02:08 nirav-raval

Merged manually. Thanks for the enhancement! Also, welcome to the team! https://pnp.github.io/cli-microsoft365/about/team

Aug 22 '25 16:08 milanholemans