cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Adds Azure DevOps guidance and updates GitHub Actions guidance. Closes #5879

Open Adam-it opened this issue 9 months ago • 3 comments

Closes #5879

Adam-it avatar Mar 20 '25 21:03 Adam-it

I will set this as draft as I guess now it makes more sense to update this to latest version of SPFx so for Node 22. Currently the examples use Node 18

Adam-it avatar Jun 02 '25 15:06 Adam-it

Should we also change this so that it's based on federated identity? Seems like the best thing to do...

martinlingstuyl avatar Jun 06 '25 06:06 martinlingstuyl

Should we also change this so that it's based on federated identity? Seems like the best thing to do...

Yes that would make sense. But I wonder would it first make sense to update m365 spfx project github workflow add and m365 spfx project azuredevops pipeline add to support scaffolding pipelines with federated identity 🤔 it has been some time already since this PR was opened 😅

Adam-it avatar Jun 08 '25 21:06 Adam-it

@Jwaegebaert, thanks for the review. I resolved all the comments, I think we may proceed 👍

Adam-it avatar Jul 27 '25 20:07 Adam-it