cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Remove deprecated options

Open milanholemans opened this issue 1 year ago • 3 comments

For the next major release, let's remove all deprecated options.

Options to remove:

  • entra group user add
    • [ ] ids
    • [ ] groupDisplayName + add short n to the new option groupName.
  • entra group user set
    • [ ] ids
    • [ ] groupDisplayName + add short n to the new option groupName.
  • entra m365group get
    • [ ] includeSiteUrl
  • entra m365group list
    • [ ] includeSiteUrl
  • entra pim role assignment eligibility list
    • [ ] includePrincipalDetails
  • entra pim role assignment list
    • [ ] includePrincipalDetails
  • entra pim role request list
    • [ ] includePrincipalDetails
  • flow list
    • [ ] includeSolutions
  • flow run get
    • [ ] includeTriggerInformation
  • graph subscription add
    • [ ] includeResourceData
  • pp solution publisher list
    • [ ] includeMicrosoftPublishers
  • purview threatassessment get
    • [ ] includeResults
  • spo file move
    • [ ] includeItemPermissions
  • spo hubsite get
    • [ ] includeAssociatedSites
  • spo hubsite list
    • [ ] includeAssociatedSites
  • spo list add
    • [ ] includedInMyFilesScope
  • spo list set
    • [ ] includedInMyFilesScope
  • spo tenant site list
    • [ ] includeOneDriveSites
  • spo term list
    • [ ] includeChildTerms
  • teams chat member add
    • [ ] includeAllHistory
  • viva engage network list
    • [ ] includeSuspended

Update list with more deprecated options if needed.

milanholemans avatar Nov 08 '24 22:11 milanholemans

@milanholemans can we include as part of this issue a follow up to this issue #6574 So when working on v11 we need to remove the deprecated include option,s leaving only the with... options or should we create a new issue to track this

Adam-it avatar Jun 15 '25 22:06 Adam-it

Feel free to add it to this one @Adam-it.

milanholemans avatar Jun 16 '25 21:06 milanholemans

ok added

Adam-it avatar Jun 17 '25 09:06 Adam-it

Can I take it?

MartinM85 avatar Aug 01 '25 13:08 MartinM85

Added an extra item for spo homesite set.

milanholemans avatar Aug 01 '25 16:08 milanholemans

Based on this comment https://github.com/pnp/cli-microsoft365/issues/6574#issuecomment-2795880949 the includedInMyFilesScope option for spo list set and spo list add should not be removed.

MartinM85 avatar Aug 03 '25 16:08 MartinM85

Great catch, @MartinM85, removed them from the list.

milanholemans avatar Aug 03 '25 17:08 milanholemans