cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Extends "spo user ensure" command with support for specifying more options. Closes #6181

Open nanddeepn opened this issue 1 year ago • 1 comments

Extends spo user ensure command with support for specifying loginName, entraGroupId, and entraGroupName options. Closes #6181

nanddeepn avatar Oct 12 '24 15:10 nanddeepn

Thank you @nanddeepn, we'll try to review it ASAP!

milanholemans avatar Oct 12 '24 17:10 milanholemans

@nanddeepn I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍 Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it avatar Oct 29 '24 10:10 Adam-it

@nanddeepn, did you find some time to look at my comments?

milanholemans avatar Dec 08 '24 17:12 milanholemans

@nanddeepn, did you find some time to look at my comments?

I have started working on it. Facing some issues with merge conflicts, but will let you know when I update the PR. Thank you.

nanddeepn avatar Dec 09 '24 09:12 nanddeepn

Hi @milanholemans Ready for review.

nanddeepn avatar Dec 09 '24 11:12 nanddeepn

Hi @milanholemans PR is ready for review. Thank you.

nanddeepn avatar Dec 21 '24 10:12 nanddeepn

Hi @nanddeepn, just a reminder, please do never merge main into your feature branch when resolving merge conflicts. Always use git rebase main and git push --force to resolve conflicts. When you merge the main branch into your PR, it takes quite some time and difficulties to get it merged with the main branch.

milanholemans avatar Dec 22 '24 16:12 milanholemans

Merged manually, thanks!

milanholemans avatar Dec 22 '24 17:12 milanholemans